Skip to content

🎨 Palette: Add visual jump controls and score accessibility to Mario game#164

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-instructions-5765362212074703337
Open

🎨 Palette: Add visual jump controls and score accessibility to Mario game#164
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-instructions-5765362212074703337

Conversation

@EiJackGH
Copy link
Copy Markdown
Owner

💡 What

Added an on-screen instruction overlay to the Mario mini-game that tells players they can press "Space" or "Up Arrow" to jump.

🎯 Why

Previously, the game only indicated the jump keybindings implicitly in the underlying JavaScript code (keydown event listener for Space and ArrowUp). New users interacting with the widget would not natively know how to play or that the Mario character could jump. Providing visible controls ensures immediate playability and greatly enhances UX.

📸 Before/After

Before: The UI only showed a score text at the top left, Mario, and the ground. No keyboard controls were provided.
After: A semi-transparent overlay "Press Space or Up Arrow to jump" is clearly visible in the top right corner of the game area.

♿ Accessibility

Added aria-live="polite" and aria-atomic="true" to the dynamic div#score tracking element. As Goombas are defeated and the internal score increments, screen readers will now gracefully announce the updated score without aggressively interrupting the user.

Note: Removed the problematic standard library module venv from the requirements.txt as it was breaking the pip setup for local verifications.


PR created automatically by Jules for task 5765362212074703337 started by @EiJackGH

… game

- Added on-screen jump controls overlay
- Fixed screen reader accessibility for score text

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant